Merge pull request #2274 from automatisch/make-editabletypography-consistent

feat(EditableTypography): make icon size and position consistent
This commit is contained in:
Ali BARIN
2025-01-13 14:48:02 +01:00
committed by GitHub
2 changed files with 5 additions and 10 deletions

View File

@@ -10,9 +10,8 @@ function EditableTypography(props) {
const {
children,
onConfirm = noop,
iconPosition = 'start',
iconSize = 'large',
sx,
iconColor = 'inherit',
disabled = false,
prefixValue = '',
...typographyProps
@@ -86,14 +85,10 @@ function EditableTypography(props) {
return (
<Box sx={sx} onClick={handleClick} editing={editing} disabled={disabled}>
{!disabled && iconPosition === 'start' && editing === false && (
<EditIcon fontSize={iconSize} sx={{ mr: 1 }} />
)}
{component}
{!disabled && iconPosition === 'end' && editing === false && (
<EditIcon fontSize={iconSize} sx={{ ml: 1 }} />
{!disabled && editing === false && (
<EditIcon fontSize="small" color={iconColor} sx={{ ml: 1 }} />
)}
</Box>
);
@@ -102,8 +97,7 @@ function EditableTypography(props) {
EditableTypography.propTypes = {
children: PropTypes.string.isRequired,
disabled: PropTypes.bool,
iconPosition: PropTypes.oneOf(['start', 'end']),
iconSize: PropTypes.oneOf(['small', 'large']),
iconColor: PropTypes.oneOf(['action', 'inherit']),
onConfirm: PropTypes.func,
prefixValue: PropTypes.string,
sx: PropTypes.object,

View File

@@ -72,6 +72,7 @@ export default function EditorLayout() {
variant="body1"
onConfirm={onFlowNameUpdate}
noWrap
iconColor="action"
sx={{ display: 'flex', flex: 1, maxWidth: '50vw', ml: 2 }}
>
{flow?.name}