Merge pull request #2468 from automatisch/aut-1540

feat(api): add delete user invitation endpoint
This commit is contained in:
Ali BARIN
2025-04-25 18:33:05 +02:00
committed by GitHub
5 changed files with 68 additions and 3 deletions

View File

@@ -0,0 +1,12 @@
import User from '../../../../models/user.js';
export default async (request, response) => {
const user = await User.query()
.findById(request.params.userId)
.where({ status: 'invited' })
.throwIfNotFound();
await user.$query().delete();
response.status(204).end();
};

View File

@@ -0,0 +1,50 @@
import Crypto from 'crypto';
import request from 'supertest';
import { beforeEach, describe, it, vi } from 'vitest';
import { createApiToken } from '../../../../../test/factories/api-token.js';
import { createUser } from '../../../../../test/factories/user.js';
import app from '../../../../app.js';
import * as license from '../../../../helpers/license.ee.js';
describe('DELETE /api/v1/user-invitations/:userId', () => {
let token;
beforeEach(async () => {
vi.spyOn(license, 'hasValidLicense').mockResolvedValue(true);
token = (await createApiToken()).token;
});
it('should soft delete user invitation and respond with no content', async () => {
const user = await createUser({ status: 'invited' });
await request(app)
.delete(`/api/v1/user-invitations/${user.id}`)
.set('x-api-token', token)
.expect(204);
});
it('should return not found response for active user', async () => {
const user = await createUser();
await request(app)
.delete(`/api/v1/user-invitations/${user.id}`)
.set('x-api-token', token)
.expect(404);
});
it('should return not found response for not existing user UUID', async () => {
const notExistingUserUUID = Crypto.randomUUID();
await request(app)
.delete(`/api/v1/user-invitations/${notExistingUserUUID}`)
.set('x-api-token', token)
.expect(404);
});
it('should return bad request response for invalid UUID', async () => {
await request(app)
.delete('/api/v1/user-invitations/invalidUserUUID')
.set('x-api-token', token)
.expect(400);
});
});

View File

@@ -1,8 +1,10 @@
import { Router } from 'express';
import getUserInvitationsAction from '../../../controllers/api/v1/user-invitations/get-user-invitations.ee.js';
import deleteUserInvitationAction from '../../../controllers/api/v1/user-invitations/delete-user-invitation.ee.js';
const router = Router();
router.get('/', getUserInvitationsAction);
router.delete('/:userId', deleteUserInvitationAction);
export default router;

View File

@@ -7,6 +7,7 @@ export const createUser = async (params = {}) => {
params.fullName = params?.fullName || faker.person.fullName();
params.email = params?.email || faker.internet.email();
params.password = params?.password || faker.internet.password();
params.status = params?.status || 'active';
const user = await User.query().insertAndFetch(params);

View File

@@ -28,10 +28,10 @@ export default defineConfig({
],
thresholds: {
autoUpdate: true,
statements: 99.43,
branches: 98.4,
statements: 99.44,
branches: 98.41,
functions: 99.09,
lines: 99.43,
lines: 99.44,
},
},
},