Global contants for default keys

This commit is contained in:
Alicia Sykes
2021-04-16 15:36:30 +01:00
parent c5f630849f
commit 56f2ba4155
8 changed files with 60 additions and 25 deletions

View File

@@ -13,6 +13,9 @@
</template>
<script>
import { localStorageKeys } from '@/utils/defaults';
export default {
name: 'KeyboardShortcutInfo',
data() {
@@ -27,7 +30,7 @@ export default {
* Note the !! just converts 'false' to false, as strings resolve to true
*/
shouldHideWelcomeMessage() {
return !!localStorage.hideWelcomeHelpers;
return !!localStorage[localStorageKeys.HIDE_WELCOME_BANNER];
},
/**
* Update session storage, so that it won't be shown again
@@ -35,7 +38,7 @@ export default {
*/
hideWelcomeHelper() {
this.shouldHide = true;
localStorage.setItem('hideWelcomeHelpers', true);
localStorage.setItem(localStorageKeys.HIDE_WELCOME_BANNER, true);
window.removeEventListener('keyup');
},
},

View File

@@ -13,7 +13,7 @@
<script>
import ThemeHelper from '@/utils/ThemeHelper';
import Defaults from '@/utils/defaults';
import Defaults, { localStorageKeys } from '@/utils/defaults';
export default {
name: 'ThemeSelector',
@@ -47,7 +47,7 @@ export default {
if (this.isThemeLocal(this.selectedTheme)) {
this.updateTheme(this.selectedTheme);
// If it's an external stylesheet, then wait for promise to resolve
} else if (this.selectedTheme !== 'Default') {
} else if (this.selectedTheme !== Defaults.theme) {
Promise.all(added).then(() => {
this.updateTheme(this.selectedTheme);
});
@@ -61,7 +61,7 @@ export default {
},
/* Get default theme */
getInitialTheme() {
return localStorage.theme || this.confTheme || Defaults.defaultTheme;
return localStorage[localStorageKeys.THEME] || this.confTheme || Defaults.theme;
},
isThemeLocal(themeToCheck) {
return this.builtInThemes.includes(themeToCheck);
@@ -77,7 +77,7 @@ export default {
} else {
this.themeHelper.theme = newTheme;
}
localStorage.setItem('theme', newTheme);
localStorage.setItem(localStorageKeys.THEME, newTheme);
},
resetToDefault() {
document.getElementsByTagName('html')[0].removeAttribute('data-theme');