From 051ed1841c204398b63e7bc16e54b1fa314606b2 Mon Sep 17 00:00:00 2001 From: Alicia Sykes Date: Mon, 27 Dec 2021 01:04:35 +0000 Subject: [PATCH] :lock: Properly deregisters event listener on destroy --- src/components/Widgets/EmbedWidget.vue | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/components/Widgets/EmbedWidget.vue b/src/components/Widgets/EmbedWidget.vue index 633b74e2..33022688 100644 --- a/src/components/Widgets/EmbedWidget.vue +++ b/src/components/Widgets/EmbedWidget.vue @@ -35,13 +35,8 @@ export default { this.initiate(); }, beforeDestroy() { - if (this.eventListener) { - window.removeEventListener(this.eventListener); - } + window.removeEventListener('load', this.injectHtml); }, - data: () => ({ - eventListener: null, - }), methods: { /* Injects users content */ injectHtml() { @@ -70,9 +65,7 @@ export default { if (document.readyState === 'complete' || document.readyState === 'loaded') { this.injectHtml(); } else { - this.eventListener = window.addEventListener('load', () => { - this.injectHtml(); - }); + window.addEventListener('load', this.injectHtml); } }, update() {