Merge pull request #2405 from automatisch/use-execution-status

feat: Use status directly from executions

packages/backend/src/controllers/api/v1/executions/get-executions.js

@@ -14,14 +14,5 @@ export default async (request, response) => {
 
   const executions = await paginateRest(executionsQuery, request.query.page);
 
-  for (const execution of executions.records) {
-    const executionSteps = await execution.$relatedQuery('executionSteps');
-    const status = executionSteps.some((step) => step.status === 'failure')
-      ? 'failure'
-      : 'success';
-
-    execution.status = status;
-  }
-
   renderObject(response, executions);
 };

packages/backend/src/models/__snapshots__/execution.test.js.snap

@@ -20,6 +20,13 @@ exports[`Execution model > jsonSchema should have correct validations 1`] = `
     "internalId": {
       "type": "string",
     },
+    "status": {
+      "enum": [
+        "success",
+        "failure",
+      ],
+      "type": "string",
+    },
     "testRun": {
       "default": false,
       "type": "boolean",

packages/backend/src/models/execution.js

@@ -14,6 +14,7 @@ class Execution extends Base {
       flowId: { type: 'string', format: 'uuid' },
       testRun: { type: 'boolean', default: false },
       internalId: { type: 'string' },
+      status: { type: 'string', enum: ['success', 'failure'] },
       deletedAt: { type: 'string' },
       createdAt: { type: 'string' },
       updatedAt: { type: 'string' },

packages/backend/src/serializers/execution.js

@@ -4,6 +4,7 @@ const executionSerializer = (execution) => {
   let executionData = {
     id: execution.id,
     testRun: execution.testRun,
+    status: execution.status,
     createdAt: execution.createdAt.getTime(),
     updatedAt: execution.updatedAt.getTime(),
   };

packages/backend/src/serializers/execution.test.js

@@ -19,6 +19,7 @@ describe('executionSerializer', () => {
     const expectedPayload = {
       id: execution.id,
       testRun: execution.testRun,
+      status: execution.status,
       createdAt: execution.createdAt.getTime(),
       updatedAt: execution.updatedAt.getTime(),
     };
@@ -26,20 +27,6 @@ describe('executionSerializer', () => {
     expect(executionSerializer(execution)).toStrictEqual(expectedPayload);
   });
 
-  it('should return the execution data with status', async () => {
-    execution.status = 'success';
-
-    const expectedPayload = {
-      id: execution.id,
-      testRun: execution.testRun,
-      createdAt: execution.createdAt.getTime(),
-      updatedAt: execution.updatedAt.getTime(),
-      status: 'success',
-    };
-
-    expect(executionSerializer(execution)).toStrictEqual(expectedPayload);
-  });
-
   it('should return the execution data with the flow', async () => {
     execution.flow = flow;
 

packages/backend/test/factories/execution.js

@@ -4,6 +4,7 @@ import { createFlow } from './flow';
 export const createExecution = async (params = {}) => {
   params.flowId = params?.flowId || (await createFlow()).id;
   params.testRun = params?.testRun || false;
+  params.status = params?.status || 'success';
 
   const execution = await Execution.query().insertAndFetch(params);
 

packages/backend/test/mocks/rest/api/v1/executions/get-execution.js

@@ -2,6 +2,7 @@ const getExecutionMock = async (execution, flow, steps) => {
   const data = {
     id: execution.id,
     testRun: execution.testRun,
+    status: execution.status,
     createdAt: execution.createdAt.getTime(),
     updatedAt: execution.updatedAt.getTime(),
     flow: {