josh/automatisch
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: adapt role-conditions tests to new permission types

Browse Source
This commit is contained in:
Jakub P
2025-04-10 09:58:57 +02:00
parent 87d37a9481
commit 01c7e0f4a9
2 changed files with 62 additions and 152 deletions
Download Patch File Download Diff File Expand all files Collapse all files

102
packages/e2e-tests/fixtures/admin/create-role-page.js
View File

@@ -14,98 +14,22 @@ export class AdminCreateRolePage extends AuthenticatedPage {
this.nameInput = page.getByTestId('name-input'); this.nameInput = page.getByTestId('name-input');
this.descriptionInput = page.getByTestId('description-input'); this.descriptionInput = page.getByTestId('description-input');
this.createButton = page.getByTestId('create-button'); this.createButton = page.getByTestId('create-button');
this.connectionRow = page.getByTestId('Connection-permission-row');
this.executionRow = page.getByTestId('Execution-permission-row');
this.flowRow = page.getByTestId('Flow-permission-row');
this.pageTitle = page.getByTestId('create-role-title'); this.pageTitle = page.getByTestId('create-role-title');
this.permissionsCatalog = page.getByTestId('permissions-catalog'); this.permissionsCatalog = page.getByTestId('permissions-catalog');
}
/** this.connectionPermissionRow = page.getByTestId(
* @param {('Connection'|'Execution'|'Flow')} subject 'Connection-permission-row'
*/ );
getRoleConditionsModal(subject) { this.flowPermissionRow = page.getByTestId('Flow-permission-row');
return new RoleConditionsModal(this.page, subject); this.executionPermissionRow = page.getByTestId('Execution-permission-row');
} this.isCreatorReadCheckbox = page
.getByTestId('isCreator-read-checkbox')
async getPermissionConfigs() { .locator('input');
const subjects = ['Connection', 'Flow', 'Execution']; this.readCheckbox = page.getByTestId('read-checkbox').locator('input');
const permissionConfigs = []; this.isCreatorManageCheckbox = page
for (let subject of subjects) { .getByTestId('isCreator-manage-checkbox')
const row = this.getSubjectRow(subject); .locator('input');
const actionInputs = await this.getRowInputs(row); this.manageCheckbox = page.getByTestId('manage-checkbox').locator('input');
Object.keys(actionInputs).forEach((action) => {
permissionConfigs.push({
action,
locator: actionInputs[action],
subject,
row,
});
});
}
return permissionConfigs;
}
/**
*
* @param {(
* 'Connection' | 'Flow' | 'Execution'
* )} subject
*/
getSubjectRow(subject) {
const k = `${subject.toLowerCase()}Row`;
if (this[k]) {
return this[k];
} else {
throw 'Unknown row';
}
}
/**
* @param {import('@playwright/test').Locator} row
*/
async getRowInputs(row) {
const inputs = {
// settingsButton: row.getByTestId('permission-settings-button')
};
for (let input of ['create', 'read', 'update', 'delete', 'publish']) {
const testId = `${input}-checkbox`;
if ((await row.getByTestId(testId).count()) > 0) {
inputs[input] = row.getByTestId(testId).locator('input');
}
}
return inputs;
}
/**
* @param {import('@playwright/test').Locator} row
*/
async clickPermissionSettings(row) {
await row.getByTestId('permission-settings-button').click();
}
/**
*
* @param {string} subject
* @param {'create'|'read'|'update'|'delete'|'publish'} action
* @param {boolean} val
*/
async updateAction(subject, action, val) {
const row = await this.getSubjectRow(subject);
const inputs = await this.getRowInputs(row);
if (inputs[action]) {
if (await inputs[action].isChecked()) {
if (!val) {
await inputs[action].click();
}
} else {
if (val) {
await inputs[action].click();
}
}
} else {
throw new Error(`${subject} does not have action ${action}`);
}
} }
async waitForPermissionsCatalogToVisible() { async waitForPermissionsCatalogToVisible() {

112
packages/e2e-tests/tests/admin/role-conditions.spec.js
View File

@@ -1,69 +1,55 @@
const { test, expect } = require('../../fixtures/index'); const { test, expect } = require('../../fixtures/index');
test( test('Check Own permissions when All are checked', async ({
'Role permissions conform with role conditions ', adminRolesPage,
async({ adminRolesPage, adminCreateRolePage }) => { adminCreateRolePage,
await adminRolesPage.navigateTo(); }) => {
await adminRolesPage.createRoleButton.click(); await adminRolesPage.navigateTo();
await adminRolesPage.createRoleButton.click();
/* await adminCreateRolePage.waitForPermissionsCatalogToVisible();
example config: {
action: 'read',
subject: 'connection',
row: page.getByTestId('connection-permission-row'),
locator: row.getByTestId('read-checkbox')
}
*/
const permissionConfigs =
await adminCreateRolePage.getPermissionConfigs();
await test.step( await adminCreateRolePage.connectionPermissionRow
'Iterate over each permission config and make sure role conditions conform', .locator(adminCreateRolePage.readCheckbox)
async () => { .check();
for (let config of permissionConfigs) { await expect(
await config.locator.click(); adminCreateRolePage.connectionPermissionRow.locator(
await adminCreateRolePage.clickPermissionSettings(config.row); adminCreateRolePage.isCreatorReadCheckbox
const modal = adminCreateRolePage.getRoleConditionsModal( )
config.subject ).toBeChecked();
);
await expect(modal.modal).toBeVisible();
const conditions = await modal.getAvailableConditions();
for (let conditionAction of Object.keys(conditions)) {
if (conditionAction === config.action) {
await expect(conditions[conditionAction]).not.toBeDisabled();
} else {
await expect(conditions[conditionAction]).toBeDisabled();
}
}
await modal.close();
await config.locator.click();
}
}
);
}
);
test( await adminCreateRolePage.flowPermissionRow
'Default role permissions conforms with role conditions', .locator(adminCreateRolePage.readCheckbox)
async({ adminRolesPage, adminCreateRolePage }) => { .check();
await adminRolesPage.navigateTo(); await expect(
await adminRolesPage.createRoleButton.click(); adminCreateRolePage.flowPermissionRow.locator(
adminCreateRolePage.isCreatorReadCheckbox
)
).toBeChecked();
const subjects = ['Connection', 'Execution', 'Flow']; await adminCreateRolePage.executionPermissionRow
for (let subject of subjects) { .locator(adminCreateRolePage.readCheckbox)
const row = adminCreateRolePage.getSubjectRow(subject); .check();
const modal = adminCreateRolePage.getRoleConditionsModal(subject); await expect(
await adminCreateRolePage.clickPermissionSettings(row); adminCreateRolePage.executionPermissionRow.locator(
await expect(modal.modal).toBeVisible(); adminCreateRolePage.isCreatorReadCheckbox
const availableConditions = await modal.getAvailableConditions(); )
const conditions = ['create', 'read', 'update', 'delete', 'publish']; ).toBeChecked();
for (let condition of conditions) {
if (availableConditions[condition]) {
await expect(availableConditions[condition]).toBeDisabled();
}
}
await modal.close();
}
} await adminCreateRolePage.connectionPermissionRow
); .locator(adminCreateRolePage.manageCheckbox)
.check();
await expect(
adminCreateRolePage.connectionPermissionRow.locator(
adminCreateRolePage.isCreatorManageCheckbox
)
).toBeChecked();
await adminCreateRolePage.flowPermissionRow
.locator(adminCreateRolePage.manageCheckbox)
.check();
await expect(
adminCreateRolePage.flowPermissionRow.locator(
adminCreateRolePage.isCreatorManageCheckbox
)
).toBeChecked();
});